refactor: move cobra/cmd/* to cobra/ #1430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/cli [deprecated]
umarcor
force-pushed
the
refactor-cobra
branch
2 times, most recently
from
8ee2f78 to
ae67f41
Compare
Merged
|
This PR is being marked as stale due to a long period of inactivity |
umarcor
force-pushed
the
refactor-cobra
branch
2 times, most recently
from
16f853c to
31779ae
Compare
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Nov 4, 2021
umarcor
force-pushed
the
refactor-cobra
branch
2 times, most recently
from
5d87b4a to
2d3794e
Compare
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Nov 16, 2021
umarcor
force-pushed
the
refactor-cobra
branch
2 times, most recently
from
849ff14 to
bec621a
Compare
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Dec 10, 2021
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Dec 10, 2021
umarcor
force-pushed
the
refactor-cobra
branch
from
bec621a to
0a80d46
Compare
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Dec 14, 2021
umarcor
force-pushed
the
refactor-cobra
branch
2 times, most recently
from
a9f935e to
5715486
Compare
umarcor
force-pushed
the
refactor-cobra
branch
from
5715486 to
755e6f0
Compare
|
Thanks for the thoughtful PR! This is being superseded by: #1604 as For further reference: #1597 |
jpmcb
added
lifecycle/wont-do
|
See spf13/cobra-cli#8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, subdir
cobracontains two sources only (main.goandMakefile). Most of the actual sources fo the CLI are located incobra/cmd. IMHO, that can be misleading becausecobrais not meant to be extended in-place. Having most of the sources as packagecmdimplies thatmain.gomight use other packages, which is not the case. I think this is a remainder of the initial layout of the repo, when cobra CLI was the only available example about how to use cobra (the library). Nowadays, there are plenty of examples. Nonethless, that belongs to the documentation.This PR moves
cobra/cmd/*tocobra/*and mergesroot.gointomain.go.