Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump gopkg.in/yaml.v2 to v3.0.1 #1713

Closed
wants to merge 1 commit into from
Closed

chore(deps): bump gopkg.in/yaml.v2 to v3.0.1 #1713

wants to merge 1 commit into from

Conversation

dnwe
Copy link

@dnwe dnwe commented May 30, 2022

@CLAassistant
Copy link

CLAassistant commented May 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/docs-generation Generation of docs via Cobra size/XS Denotes a PR that changes 0-9 lines labels May 30, 2022
cfc4n
cfc4n reviewed May 30, 2022
View reviewed changes
Copy link

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my project eCapture, there is also a risk note about yaml.v2 because it also uses this class library. Can this PR be merged ASAP? thanks.

umarcor
umarcor approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marckhouzam
Copy link
Collaborator

Thanks for the contribution @dnwe!
Somehow it fell through the cracks and an identical one was merged instead in #1766.
Yours came in first so should have been the one merged but we just didn't see it through the list, sorry.

The good news is, your requested change is now present in Cobra.

I'm going to close this as a duplicate of #1766.

@umarcor umarcor mentioned this pull request Aug 14, 2022
Closed
@dnwe
Copy link
Author

dnwe commented Aug 14, 2022

No worries, I just happened to have the change ready on my own fork so submitted it for convenience

@dnwe dnwe deleted the yaml-v3 branch August 14, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfc4n cfc4n cfc4n left review comments

@umarcor umarcor umarcor approved these changes

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
area/docs-generation Generation of docs via Cobra size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dnwe @CLAassistant @marckhouzam @cfc4n @Jacalz @umarcor