-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest go-md2man #2201
Conversation
Since cpuguy83/go-md2man 2.0.5 no paraTag is written after "SEE ALSO". With go-md2man 2.0.4: .SH SEE ALSO .PP \fBroot-bbb(1)\fP, \fBroot-ccc(1)\fP With go-md2man 2.0.5: .SH SEE ALSO \fBroot-bbb(1)\fP, \fBroot-ccc(1)\fP See: cpuguy83/go-md2man#122 Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This breaks compilation with go 1.17, meaning it will force projects to upgrade to go 1.18. Although it may be time to let go of these Go versions I want this to be a conscious decision. And if we go that route we’ll need to update CI and cobra go.mod. Also, I have to look at why CI didn’t run completely with this change which would have detected this early. @mikelolasagasti @thaJeztah can to clarify the value of this change? |
Looking from my phone, but my first guess would be this PR; I think that would be ok to revert to keep compatibility as it's not critical; WDYT @cpuguy83 ? |
That's fine. |
☝️ I opened a PR to fix compatibility; once that (and related PRs) are reviewed and merged, we can probably tag a v2.0.6 and update here. |
@marckhouzam v2.0.6 was tagged; I opened a PR to update; #2206 |
Thanks for dealing with this so quickly @thaJeztah @cpuguy83 |
Since cpuguy83/go-md2man 2.0.5 no paraTag is written after "SEE ALSO".
With go-md2man 2.0.4:
With go-md2man 2.0.5:
See: cpuguy83/go-md2man#122