Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest go-md2man #2201

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

mikelolasagasti
Copy link
Contributor

Since cpuguy83/go-md2man 2.0.5 no paraTag is written after "SEE ALSO".

With go-md2man 2.0.4:

.SH SEE ALSO
.PP
\fBroot-bbb(1)\fP, \fBroot-ccc(1)\fP

With go-md2man 2.0.5:

.SH SEE ALSO
\fBroot-bbb(1)\fP, \fBroot-ccc(1)\fP

See: cpuguy83/go-md2man#122

Since cpuguy83/go-md2man 2.0.5 no paraTag is written after "SEE ALSO".

With go-md2man 2.0.4:

.SH SEE ALSO
.PP
\fBroot-bbb(1)\fP, \fBroot-ccc(1)\fP

With go-md2man 2.0.5:

.SH SEE ALSO
\fBroot-bbb(1)\fP, \fBroot-ccc(1)\fP

See: cpuguy83/go-md2man#122

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/docs-generation Generation of docs via Cobra label Oct 31, 2024
Copy link
Contributor

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marckhouzam marckhouzam merged commit 8519630 into spf13:main Dec 11, 2024
3 checks passed
@marckhouzam marckhouzam added this to the 1.9.0 milestone Dec 11, 2024
@marckhouzam
Copy link
Collaborator

This breaks compilation with go 1.17, meaning it will force projects to upgrade to go 1.18.
With the multitude of projects using cobra, there very well may be some using go 1.17 (or even 1.15 or 1.16).

Although it may be time to let go of these Go versions I want this to be a conscious decision. And if we go that route we’ll need to update CI and cobra go.mod.

Also, I have to look at why CI didn’t run completely with this change which would have detected this early.

@mikelolasagasti @thaJeztah can to clarify the value of this change?

@thaJeztah
Copy link
Contributor

Looking from my phone, but my first guess would be this PR; I think that would be ok to revert to keep compatibility as it's not critical; WDYT @cpuguy83 ?

@cpuguy83
Copy link

That's fine.

@thaJeztah
Copy link
Contributor

☝️ I opened a PR to fix compatibility; once that (and related PRs) are reviewed and merged, we can probably tag a v2.0.6 and update here.

@thaJeztah
Copy link
Contributor

@marckhouzam v2.0.6 was tagged; I opened a PR to update; #2206

@marckhouzam
Copy link
Collaborator

Thanks for dealing with this so quickly @thaJeztah @cpuguy83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs-generation Generation of docs via Cobra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants