Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic PowerShell completions #797

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Basic PowerShell completions #797

merged 2 commits into from
Jun 7, 2019

Conversation

frigus02
Copy link
Contributor

This implements basic PowerShell completions using Register-ArgumentCompleter as suggested in #387.

It's heavily based on the amazing work in https://github.com/clap-rs/clap.

The support is pretty basic. It supports subcommands and flags. But it lacks any of the special things supported by the Bash completions like required, custom or filename flags. Also I'm sure I missed other edge cases 🙂.

However I think this is a good start and it seems to work quite well for me.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2018

CLA assistant check
All committers have signed the CLA.

@spf13
Copy link
Owner

spf13 commented Jun 7, 2019

Seems like a good start to supporting powershell.

@spf13 spf13 merged commit d658160 into spf13:master Jun 7, 2019
@frigus02 frigus02 deleted the powershell-completions branch June 7, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants