Vgo

[jharshman]

Moves to resolve Issue #756

This was a re-work of the cobra code generator to allow it to work outside of the GOPATH and hence be compatible with Go modules (vgo) introduced in Go 1.11. This change introduces a new flag to the init command and deprecates the --package flag from the add command. With all these changes the flows remains relatively the same. Any exceptions are outlined below.

Changes

• Add a --pkg-name flag to the init command which takes a string representing the package name.
  e.g: --pkg-name github.com/spf14/hugo
• For adding commands, you should be inside your project root.
• Init will no longer fail on non-empty directories.

[ironsalsa]

I ran into what this fixes today. Upvote to anything that lets us use the Go Modules way of life, as some of my projects have been moved over by necessity and I'm missing the generator!

[jharshman]

@ironsalsa Yeah I think there is a lot of desire for this feature, but it's not really getting much attention from the maintainers.

[eparis]

I'm actually hoping to take a look at all of the vgo PRs today.... hopefully. I know we need it.

[jharshman]

👍 that would be awesome @eparis thanks!!

[shawncatz]

👍

[jharshman]

@eparis were you able to review this PR?

[eine]

ping...

[kyriediculous]

@eparis So it's been a few months now, did you manage to review it?

This is a high priority PR...

[jharshman]

I've been using my fork of this for some time just to ensure that the usage makes sense and is stable.
So far so good. I'm going to do a little clean up and rebase against upstream.

[williamokano]

Still nothing from the maintainers? This feature would be awesome :)

[jozuenoon]

🏓

[tsal]

@jharshman since it doesn't look like we're ever going to hear back from the maintainers on this - can you provide a write-up of how you got this working locally? I tried checking out your branch and doing a "go install ." but the binary doesn't recognize the new flag. I suspect I'm missing something dreadfully obvious.

[jharshman]

@tsal go install works for me. Make sure you have the branch checked out in your $GOPATH and run go install github.com/spf13/cobra/cobra

[andrewmeissner]

@spf13 ping

[gmelillo]

Some news about that?
will be really useful to have it merged

[umarcor]

@jharshman since it doesn't look like we're ever going to hear back from the maintainers on this - can you provide a write-up of how you got this working locally? I tried checking out your branch and doing a "go install ." but the binary doesn't recognize the new flag. I suspect I'm missing something dreadfully obvious.

I hope that the following example is useful to you:

#!/bin/sh

cat > run.sh <<-EOF
apk add git
git clone -b vgo https://github.com/jharshman/cobra cobra
cd cobra/cobra
go install
cobra init --pkg-name github.com/pkg/name
EOF

$(command -v winpty) docker run --rm -it golang:alpine sh -c "$(cat run.sh)"

[tsal]

When I get a review button, I'm gonna use it.