Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive zsh completion from bash completion #828

Closed
wants to merge 1 commit into from

Conversation

corneliusweig
Copy link

This is a temporary fix to get some zsh completion. The idea is taken from kubectl where the bash completion script is wrapped with some zsh adapter code. The zsh magic is taken from kubectl.

There is an old PR #646 where a native zsh completion should be implemented. Sad thing is, there has been no progress for more than half. Since there should be a working out-of-the box solution, we should use this as an temporary drop-in until there is a better native zsh implementation.

Also see discussion in #107

This is a temporary fix to get some zsh completion. The idea is taken from kubectl where the bash completion script is wrapped with some zsh adapter code. The zsh magic is taken from kubectl.
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2019

CLA assistant check
All committers have signed the CLA.

@spf13
Copy link
Owner

spf13 commented Jun 7, 2019

@corneliusweig I merged #646 today. Is this still relevant at all?

@corneliusweig
Copy link
Author

@spf13 No that completely supersedes my port. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants