Configure (and autodiscover) directives #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs love :) I even have a rebase locally but main diverged further :D (Writing this just to state I'm not forgetting it.) |
|
@JulienPalard is the feature welcome? Happy to bring it up to date but would welcome design review. A |
|
@AA-Turner Yes I think this is a good idea. |
AA-Turner
force-pushed
the
directive-getter
branch
from
327a23f
to
2f7207a
Compare
|
I fixed main so in pytest we see the output (in case it differs from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1, closes #25 (if implemented)
This is a proof of concept of configurable directive support and autodiscovery of directives.
Directive names can be listed in the
linttable ofsphinx.tomlor fromtools.sphinx.lintinpyproject.toml.Auto discovery is currently in
directivegetter.py-- this would probably need to be refactored intosphinxlint/blah.I'd welcome thoughts or feedback!
A