Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.12, drop EOL 3.7, add pyupgrade pre-commit hook #139

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Add support for Python 3.12, drop EOL 3.7, add pyupgrade pre-commit hook #139

merged 6 commits into from
Oct 28, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 28, 2023

No description provided.

@welcome
Copy link

welcome bot commented Oct 28, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@consideRatio consideRatio changed the title Add support for Python 3.12, drop EOL 3.7 Add support for Python 3.12, drop EOL 3.7, add pyupgrade pre-commit hook Oct 28, 2023
@consideRatio
Copy link
Contributor

Oh black doesn't need the explicit supported versions listed by using pyproject.toml's information instead? Nice, needing to specify all those has bugged me a bit.

consideRatio
consideRatio approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work!!! I think this should be fine to merge, I'll go for it!

@consideRatio consideRatio merged commit d06c8ec into sphinx-doc:main Oct 28, 2023
6 checks passed
@welcome
Copy link

welcome bot commented Oct 28, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@hugovk
Copy link
Contributor Author

hugovk commented Oct 28, 2023

Oh black doesn't need the explicit supported versions listed by using pyproject.toml's information instead? Nice, needing to specify all those has bugged me a bit.

Yep! It was new in 23.1.0:

https://ichard26.github.io/blog/2023/01/black-23.1.0/#better-default-for---target-version-if-pep-621-python-requires-is-available

@foarsitter foarsitter mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
maintainance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @consideRatio