Add a basic integration test #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
May 6, 2024
return42
reviewed
May 30, 2024
Comment on lines
-26
to
+30
| def main(): | ||
| def main(argv=()): | ||
| """Actual application logic.""" | ||
| colorama.init() | ||
|
|
||
| args, build_args = _parse_args(sys.argv[1:]) | ||
| args, build_args = _parse_args(list(argv)) |
There was a problem hiding this comment.
This patch breaks the installed scripts .. you can reproduce it by:
$ cd /tmp/
$ python -m venv myenv
...
$ . myenv/bin/activate
(myenv) $ pip install 'git+https://github.com/sphinx-doc/sphinx-autobuild'
...
(myenv) $ sphinx-autobuild
usage: sphinx-autobuild [OPTIONS] SOURCEDIR OUTPUTDIR [FILENAMES...]
sphinx-autobuild: error: the following arguments are required: SOURCE_DIR, OUTPUT_DIR, filenamesRelated: #162
return42
added a commit
to return42/sphinx-autobuild
that referenced
this pull request
May 30, 2024
…rgv[1:]` To reproduce the issue read comment [1]. [1] https://github.com/sphinx-doc/sphinx-autobuild/pull/160/files#r1620387971 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/sphinx-autobuild
that referenced
this pull request
May 30, 2024
…rgv[1:]` To reproduce the issue read comment [1]. [1] https://github.com/sphinx-doc/sphinx-autobuild/pull/160/files#r1620387971 Closes: sphinx-doc#162 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should catch obvious errors of the form of #155.
A