Fix warnings when files are overwritten in the build directory. #12627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't want to have a new warning in a micro release, hence using A |
AA-Turner
reviewed
Jul 20, 2024
I updated the tests accordingly (since the message would no more be printed on the warnings stream). |
AA-Turner
reviewed
Jul 20, 2024
|
Thanks! A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @AA-Turner
I fixed the test (it was due to the two files having the same file size, and
filecmp.cmp()returned True because it did not checked the contents). I also added a message for the assertion since it helps in debugging the error location.