Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_StrPath is dead; long live _StrPath #12690

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

AA-Turner
Copy link
Member

Closes #12686.

@AA-Turner AA-Turner added this to the 8.0.0 milestone Jul 26, 2024
@AA-Turner AA-Turner merged commit b511537 into sphinx-doc:master Jul 26, 2024
19 checks passed
@AA-Turner AA-Turner deleted the strpath branch July 26, 2024 16:33
_PATH_NAME = Path().__class__.__name__

_MSG = (
'Sphinx 8 will drop support for representing paths as strings. '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say Sphinx 9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done in 46ce447.

A

@jfbu
Copy link
Contributor

jfbu commented Jul 29, 2024

ping @AA-Turner with this commit I started seeing

copying static files... /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/filecmp.py:62: RemovedInSphinx90Warning: Sphinx 8 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.
  outcome = _cache.get((f1, f2, s1, s2))

when building our own html docs. I could not identify where the last line comes from, I thought a remnant of some debugging or may some doctest (but this commit did not touch doc/)

Python version: 3.12.3 (CPython)
Docutils version: 0.20.1 
Pygments version: 2.18.0
Jinja2 version: 3.1.4

With 8.0.0rc1 I only see

copying static files... done
copying extra files... done

@AA-Turner
Copy link
Member Author

#12708 hopefully fixes this.

A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QEMU fails to build with sphinx 8
3 participants