Skip to content

Commit

Permalink
Remove Sphinx as a required dependency (#15)
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
  • Loading branch information
phlax and AA-Turner committed Jan 13, 2024
1 parent 4427b86 commit b4d64f5
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install .[test]
python -m pip install .[test,standalone]
- name: Test with pytest
run: python -m pytest -vv --durations 25
Expand Down
7 changes: 7 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
Release 1.0.7 (unreleased)
==========================

* Remove Sphinx as a required dependency, as circular dependencies may cause
failure with package managers that expect a directed acyclic graph (DAG)
of dependencies.

Release 1.0.6 (2023-08-14)
==========================

Expand Down
7 changes: 4 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ classifiers = [
"Topic :: Text Processing",
"Topic :: Utilities",
]
dependencies = [
"Sphinx>=5",
]
dependencies = []
dynamic = ["version"]

[project.optional-dependencies]
Expand All @@ -53,6 +51,9 @@ lint = [
"mypy",
"docutils-stubs",
]
standalone = [
"Sphinx>=5",
]

[[project.authors]]
name = "Georg Brandl"
Expand Down
1 change: 1 addition & 0 deletions sphinxcontrib/qthelp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ def get_project_files(self, outdir: str | os.PathLike[str]) -> list[str]:


def setup(app: Sphinx) -> dict[str, Any]:
app.require_sphinx('5.0')
app.setup_extension('sphinx.builders.html')
app.add_builder(QtHelpBuilder)
app.add_message_catalog(__name__, path.join(package_dir, 'locales'))
Expand Down

0 comments on commit b4d64f5

Please sign in to comment.