Add preferred_ttl field to SVID.NewDownstreamX509CA #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
evan2645,
amartinezfayo and
rturner3
as code owners
This field will facilitate using the downstream CA TTL configuration as a sane default for the downstream intermediate CA cert lifetime. See SPIRE issue #5236. Also removed an unused import. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
force-pushed
the
azdagron/add-preferred-ttl
branch
from
05f0fac
to
acbf160
Compare
MarcosDY
approved these changes
Jun 27, 2024
MarcosDY
pushed a commit
that referenced
this pull request
Aug 1, 2024
This field will facilitate using the downstream CA TTL configuration as a sane default for the downstream intermediate CA cert lifetime. See SPIRE issue #5236. Also removed an unused import. Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field will facilitate using the downstream CA TTL configuration as a sane default for the downstream intermediate CA cert lifetime.
See SPIRE issue #5236.
Also removed an unused import.