LocalAuthority service: add upstream_authority_subject_key_id field to AuthorityState #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o AuthorityState Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
evan2645,
azdagron and
rturner3
as code owners
…sponse and RevokeX509UpstreamAuthorityResponse Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
MarcosDY
approved these changes
Aug 27, 2024
MarcosDY
pushed a commit
to MarcosDY/spire-api-sdk
that referenced
this pull request
Oct 21, 2024
…o AuthorityState (spiffe#65) * LocalAuthority service: add upstream_authority_subject_key_id field to AuthorityState Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> * Add upstream_authority_subject_key_id to TaintX509UpstreamAuthorityResponse and RevokeX509UpstreamAuthorityResponse Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> --------- Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
MarcosDY
pushed a commit
that referenced
this pull request
Oct 21, 2024
…o AuthorityState (#65) * LocalAuthority service: add upstream_authority_subject_key_id field to AuthorityState Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> * Add upstream_authority_subject_key_id to TaintX509UpstreamAuthorityResponse and RevokeX509UpstreamAuthorityResponse Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> --------- Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream_authority_subject_key_idfield to theAuthorityStatemessage,TaintX509UpstreamAuthorityResponseandRevokeX509UpstreamAuthorityResponse. This helps to improve the experience when tainting upstream authorities, since knowing what's the upstream authority that signed the old local X.509 authority is required to taint an upstream authority.