Update CHANGELOG.md with v0.10.1 release #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
azdagron
reviewed
Jun 15, 2020
CHANGELOG.md
Outdated
Comment on lines
5
to
6
| - Improved cgroup path parsing in the `docker` workload attestor plugin (#1605) | ||
| - Improved container ID parsing in the `k8s` workload attestor plugin (#1649) |
There was a problem hiding this comment.
These should be worded similarly since they both involve parsing the container ID from the cgroup path
There was a problem hiding this comment.
(I recognize the PRs themselves didn't have consistent wording :) )
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
|
Thanks @amartinezfayo. Solid list. We've talked for a while about how to best structure changelogs to look more like release notes. As discussed over slack a suggestion is to breakdown the list into two categories; what's new, and what's changed. Something along the lines of: What's New
What's Changed
|
anvega
reviewed
Jun 19, 2020
CHANGELOG.md
Outdated
| @@ -1,5 +1,14 @@ | |||
| # Changelog | |||
|
|
|||
| ## [0.10.1] - 2020-06-19 | |||
| - Added Upstream Authority `vault` Plugin (#1611, #1632) | |||
There was a problem hiding this comment.
Suggested change
| - Added Upstream Authority `vault` Plugin (#1611, #1632) | |
| - 'vault' as Upstream Authority built-in plugin(#1611, #1632) |
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
azdagron
approved these changes
Jun 22, 2020
amartinezfayo
added a commit
to amartinezfayo/spire
that referenced
this pull request
Jun 22, 2020
amartinezfayo
added a commit
to amartinezfayo/spire
that referenced
this pull request
Jun 22, 2020
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.c
amartinezfayo
added a commit
to amartinezfayo/spire
that referenced
this pull request
Jun 23, 2020
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CHANGELOG.md with v0.10.1 release.
The release candidate commit is 6ea1530.
Release date is tentatively set to 2020-06-19. If needed, the PR will be updated with the final date.