Update the "vault" plugin document. #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyosi
requested review from
ajessup,
amartinezfayo,
APTy,
azdagron and
evan2645
as code owners
There was a problem hiding this comment.
Thank you @hiyosi.
I believe that this clarifies the requirements using the TOKEN auth method. Can we document about the other methods also?
| @@ -23,6 +23,16 @@ The plugin supports **Client Certificate**, **Token** and **AppRole** authentica | |||
| - **Token** method authenticates to Vault using the token in a HTTP Request header. | |||
| - **AppRole** method authenticates to Vault using a RoleID and SecretID that are issued from Vault. | |||
|
|
|||
| The plugin must have at least the following permissions(Vault Policy). | |||
There was a problem hiding this comment.
This sentence is somehow confusing for me. Instead of referring to the "plugin permissions", I would rather refer to the capabilities required in the policy. Which is actually pointed below.
We may say something along the lines of
The configured token needs to be attached to a policy that has at least the following capabilities: ...
What do you think?
|
Thank you for review! |
amartinezfayo
previously approved these changes
Jun 19, 2020
|
@hiyosi can you update the branch so we can merge this? Thanks! |
Signed-off-by: Tomoya Usami <tousami@zlab.co.jp>
|
@amartinezfayo just updated the branch 😀 |
amartinezfayo
pushed a commit
to amartinezfayo/spire
that referenced
this pull request
Jun 22, 2020
Signed-off-by: Tomoya Usami <tousami@zlab.co.jp> Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
pushed a commit
to amartinezfayo/spire
that referenced
this pull request
Jun 22, 2020
Signed-off-by: Tomoya Usami <tousami@zlab.co.jp>
amartinezfayo
pushed a commit
to amartinezfayo/spire
that referenced
this pull request
Jun 23, 2020
Signed-off-by: Tomoya Usami <tousami@zlab.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
The UpstreamAuthority
vaultdocument.Description of change
Update the UpstreamAuthority
vaultplugin document.Which issue this PR fixes
#1611 (comment)
and related to #1664