Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cache update deduplication per fetch cycle #5509

Merged
merged 36 commits into from
Oct 17, 2024
Merged

Implement cache update deduplication per fetch cycle #5509

merged 36 commits into from
Oct 17, 2024

Commits on Sep 20, 2024

  1. Intial work on backoff algorithm. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    208d1cf View commit details
    Browse the repository at this point in the history

  2. Push after refactoring registration entry event tracking. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c6d23aa View commit details
    Browse the repository at this point in the history

  3. Final refactoring done. Need to fix unit tests. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b4d2de9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Reworked some of the unit tests to the refactored algorithm. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bf6ad3c View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Saving work off so I can switch machines. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f81942f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Fix compliation. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4118679 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Unit test fixes and restoration of authorized_entryfetcher.go. 

    Improved testing of authorized_entryfetcher_attested_nodes.go
Minor fixes to authorized_entryfetcher_regisration_entries.go
Fixed authorizedentries/cache_test.go
Better documentation for eventTracker.go
Fixed lack of sub-minute polling on eventTracker.go
Fixed unit tests to match sub-minute polling abilities.

Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    791b503 View commit details
    Browse the repository at this point in the history

  2. Add in boundary builder unit tests. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    aad7444 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Add unit tests for updating the node cache from the database. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    806ebf7 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Added loadCache testing for authorized entries registered entry. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8ab4d68 View commit details
    Browse the repository at this point in the history

  2. Add in updates to fakedatastore. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b5a068a View commit details
    Browse the repository at this point in the history

  3. Add unit test for authorized entryfetcher registration entries. 

    Renamed items in authorized entryfetcher attested nodes to not conflict.

Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a43e9ef View commit details
    Browse the repository at this point in the history

  4. Add poll entries testing to authorized entryfetcher registration entr… 

    …ies.

Renamed similar test in attested nodes unit test to not conflict.

Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2eb66d1 View commit details
    Browse the repository at this point in the history

  5. Add in new entry unit tests for auth entry fetcher registraiton entries. 

    Rename equivalent attested nodes unit test to avoid collision.
Rename registration entries func call to match attested nodes pattern.

Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7c645c4 View commit details
    Browse the repository at this point in the history

  6. Update cache unit test for authorized entryfetcher registration entries. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9278f36 View commit details
    Browse the repository at this point in the history

  7. Fix datastore wrapper_test. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    673a480 View commit details
    Browse the repository at this point in the history

  8. Fix unit tests. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9d0986b View commit details
    Browse the repository at this point in the history

  9. Fix some linting issues. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    978fbab View commit details
    Browse the repository at this point in the history

  10. Fix linting issues. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a0a2d49 View commit details
    Browse the repository at this point in the history

  11. Fix grammar in func calls / structs. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0a21834 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into backoff

    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6036b1c View commit details
    Browse the repository at this point in the history

  13. Fix spelling items in comments for code review. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    61feaa4 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Better commentary around BoundaryBuilder. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c5457cd View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Fix update of poll count when an item is polled. 

    This directs the item to look into the next poll boundary, which prevents
a bug where the items wasn't finding the index to report, as it believed
it was waiting on a future event, that occurred in the past.

Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d4225bf View commit details
    Browse the repository at this point in the history

  2. Fix eventTracker for multiple boundaries. 

    Added unit testing for first three boundaries.

Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    55f8254 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Removed inner loop assignment as capture problem fixed in language. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9a9a942 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into backoff

    @edwbuck
    edwbuck committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9205427 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'main' into backoff

    @edwbuck
    edwbuck committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    24e772e View commit details
    Browse the repository at this point in the history

  2. Fixed small typos and style choices for code review. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ee1ba09 View commit details
    Browse the repository at this point in the history

  3. Fixed export of metrics selector name sets in unit tests. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8fc09e3 View commit details
    Browse the repository at this point in the history

  4. Add in sync.Pool semantics to avoid memory trashing / overallocation. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ac075b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Remove backoff polling. 

    This limits the solution to full polling as before, but still preserves
the work that would close spiffe#5349.

Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    59f2b7a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Add in buffer resetting for eventTracker, remove TODO items. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    de28e0d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Fixes for freeing the shared buffer between eventTracker and its users. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    28bd44d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into backoff

    @edwbuck
    edwbuck authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    889cc29 View commit details
    Browse the repository at this point in the history

  3. fix pool usage to satisfy linter 

    Signed-off-by: Andrew Harding <azdagron@gmail.com>
    @azdagron
    azdagron committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f0cbc4b View commit details
    Browse the repository at this point in the history