Enable expand env for oidc discovery provider #5689
+53
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spiffe#5688 Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Closed
5 tasks
rturner3
reviewed
Dec 18, 2024
| require.Error(err) | ||
| require.Contains(err.Error(), "unable to load configuration:") | ||
|
|
||
| err = os.WriteFile(confPath, []byte(minimalServerAPIConfig), 0600) | ||
| require.NoError(err) | ||
|
|
||
| config, err := LoadConfig(confPath) | ||
| config, err := LoadConfig(confPath, false) |
There was a problem hiding this comment.
Can you also add a test case that expands environment variables defined in the config and verifies that the expansion works as expected?
There was a problem hiding this comment.
yes. I'll add a test for it.
rturner3
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5688