Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spire server info requirement from the frontend #214 #261

Merged
merged 8 commits into from
Jun 14, 2023
Merged

Remove spire server info requirement from the frontend #214 #261

merged 8 commits into from
Jun 14, 2023

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented Jun 12, 2023 •
edited
Loading

Addresses: #214

  • PR includes some error handling and user notification

@mamy-CS
remove spire config req from tornjak spire server
23d41ce 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS
update tornjk serverinfo with debugserver info
4e6c067 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS mamy-CS mentioned this pull request Jun 12, 2023
Closed
@mamy-CS
remove .idea files
b4e1452 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS
add .idea folder to gitignore
3c81411 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS
adding accidental local builds
827ccbc 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS
adding dependency frontend container
7133e48 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mrsabath mrsabath added this to the 1.3.x milestone Jun 13, 2023
@mamy-CS
status code 204 for no content server info config
cdfb413 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
maia-iyer
maia-iyer approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested end-to-end. Just one important nit comment about the type of debugserver

tornjak-frontend/src/redux/actions/types.ts Outdated Show resolved Hide resolved
tornjak-frontend/src/components/types.ts Show resolved Hide resolved
tornjak-frontend/src/components/tornjak-server-info.tsx Show resolved Hide resolved
@maia-iyer maia-iyer mentioned this pull request Jun 14, 2023
Merged
@mamy-CS
nits and comments
3ab98f6 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS mamy-CS merged commit c69ac19 into v1.3 Jun 14, 2023
@maia-iyer maia-iyer deleted the spire-config-req-frontend-update branch August 11, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maia-iyer maia-iyer maia-iyer approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@mamy-CS @maia-iyer @mrsabath