Merge v1.5 into main #373
Merged
Merge v1.5 into main #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4.0.1...v4.1.0) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3.6.0...v3.7.0) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.7.0...v3.8.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.5.3...v3.6.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.0 to 3.8.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.8.0...v3.8.1) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* UBI migration for frontend Signed-off-by: Andrew Block <andy.block@gmail.com> * Updated backend for UBI based container Signed-off-by: Andrew Block <andy.block@gmail.com> * Updated permissions on frontend container Signed-off-by: Andrew Block <andy.block@gmail.com> --------- Signed-off-by: Mariusz Sabath <mrsabath@gmail.com> Co-authored-by: Andrew Block <andy.block@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.6.0...v4.0.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 2.2.0 to 3.0.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2.2.0...v3.0.0) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Added workflows for ubi image Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Set Dockerfiles for ubi image Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
* Added labels Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Update Dockerfile.backend-container.ubi Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.9.0 to 0.17.0. - [Commits](golang/net@v0.9.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Added UBI description Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Added Alpine to image description Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Update Dockerfile.backend-container Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Dockerfile.backend-container.ubi Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Dockerfile.frontend-container Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Dockerfile.frontend-container.ubi Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.1 to 4.0.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.8.1...v4.0.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.55.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.55.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net>
* Moved golang files up a directory Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Remove run_tornjak script Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Adjusted Gofiles to reflect new structure Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Moved docker-compose file to examples folder Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Reverting accidentally added changes Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Moved Keycloak example Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * moved backend script Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * renamed tornjak frontend folder Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * adjusted lcoation of frontend Dockerfiles Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * re-add Dockerfile for frontend Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * add accidentally ignored packages Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * fixed rebase error Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/go-jose/go-jose/releases) - [Changelog](https://github.com/go-jose/go-jose/blob/v3/CHANGELOG.md) - [Commits](go-jose/go-jose@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: github.com/go-jose/go-jose/v3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Updating some doc and add troubleshoot Signed-off-by: Kidus Teferra <kidus.teferra@ibm.com> * Updating quick start docs Signed-off-by: Kidus Teferra <kidus.teferra@ibm.com> * Troubleshoot section update Signed-off-by: Kidus Teferra <kidus.teferra@ibm.com> --------- Signed-off-by: Kidus Teferra <54513597+kidus0214@users.noreply.github.com> Co-authored-by: Kidus Teferra <kidus.teferra@ibm.com>
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.1.0 to 5.0.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4.1.0...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Bumps [axios](https://github.com/axios/axios) from 0.21.4 to 1.6.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.21.4...v1.6.0) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net>
* update port comment (#295) Signed-off-by: Mariusz Sabath <mrsabath@gmail.com> * Removed unsupported architectures in tutorial Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * nit fix Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Mariusz Sabath <mrsabath@gmail.com> Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.0.1...v4.0.2) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.7.0 to 3.7.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3.7.0...v3.7.1) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.7.1 to 4.0.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3.7.1...v4.0.0) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Benak961 <91481367+Benak961@users.noreply.github.com>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Karen Jude <kjude79@gmail.com>
* refactored Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Removed run dependency backend Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
* multi arch image support arm64 added including ci build Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net> * update qemu and buildx to v3 Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net> * add to label Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net> * update label format Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net> --------- Signed-off-by: Mohammed Abdi <mohammma@usc.edu> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1 to 3. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@v1...v3) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Added --load flag to multi arch build Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Use --push flag instead of --load Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Add back old build and create new target for multiarch build Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * modified release frontend image target Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removed erroneous tab Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
* Multiarch build Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * multi-arch backend images Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * added support for ubi Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose) from 3.0.1 to 3.0.3. - [Release notes](https://github.com/go-jose/go-jose/releases) - [Changelog](https://github.com/go-jose/go-jose/blob/v3.0.3/CHANGELOG.md) - [Commits](go-jose/go-jose@v3.0.1...v3.0.3) --- updated-dependencies: - dependency-name: github.com/go-jose/go-jose/v3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update ubi image Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net> * install full ubi dependencies in build stage Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net> * downgrade nodejs to 18 for consistency Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net> --------- Signed-off-by: Mohammed Abdi <mohammma@usc.edu> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP.attlocal.net>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.1...v4.1.2) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v3.0.0...v3.1.0) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
mrsabath
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.