Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spire server unique identifier #472

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented Aug 2, 2024

  • Using trust domain and path as spire server unique identifier for federation experiments
    Server ID: "trust-domain"/"path"

Signed-off-by: MohammedAbdi <mohammma@usc.edu>
@mamy-CS mamy-CS self-assigned this Aug 2, 2024
Signed-off-by: MohammedAbdi <mohammma@usc.edu>
@mamy-CS mamy-CS added enhancement New feature or request frontend Tornjak UI (Frontend) In Review labels Aug 2, 2024
@mamy-CS mamy-CS linked an issue Aug 2, 2024 that may be closed by this pull request
@maia-iyer maia-iyer added this to the 1.8.0 milestone Aug 6, 2024
Signed-off-by: MohammedAbdi <mohammma@usc.edu>
Signed-off-by: MohammedAbdi <mohammma@usc.edu>
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit; personal preference that trust domain is bolder than the path. Otherwise, looks good!

frontend/src/components/navbar.tsx Outdated Show resolved Hide resolved
Signed-off-by: MohammedAbdi <mohammma@usc.edu>
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@maia-iyer maia-iyer merged commit 1371d54 into dev Aug 12, 2024
8 checks passed
@maia-iyer maia-iyer deleted the spire-server-unique-identifier branch August 13, 2024 14:23
maia-iyer pushed a commit that referenced this pull request Sep 17, 2024
* add trust domain as spire server unique identifier

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

* update component

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

* add spire server path

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

* update server id

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

* updat trust domain view to be bolder for identification

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

---------

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
maia-iyer pushed a commit that referenced this pull request Sep 17, 2024
* add trust domain as spire server unique identifier

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

* update component

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

* add spire server path

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

* update server id

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

* updat trust domain view to be bolder for identification

Signed-off-by: MohammedAbdi <mohammma@usc.edu>

---------

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Tornjak UI (Frontend) Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unique spire server identifier
2 participants