Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index ordering when merging values on import #463

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Oct 30, 2024

In case of string indices, we want to append the new parameter after the old one.

No associated issue.

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.20%. Comparing base (d076802) to head (152d1d1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
spinedb_api/parameter_value.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #463   +/-   ##
=======================================
  Coverage   79.20%   79.20%           
=======================================
  Files          77       77           
  Lines       10111    10112    +1     
  Branches     1510     1509    -1     
=======================================
+ Hits         8008     8009    +1     
- Misses       1756     1757    +1     
+ Partials      347      346    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In case of string indices, we want to append the new parameter after
the old one.
@soininen soininen force-pushed the fix_value_merge_on_import branch from 9592111 to 152d1d1 Compare October 30, 2024 11:54
@soininen soininen merged commit 4677999 into master Oct 30, 2024
13 checks passed
@soininen soininen deleted the fix_value_merge_on_import branch October 30, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant