Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pivoted import mappings using column headers #465

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Nov 4, 2024

In certain scenarios mapping's value would be accidentally set to None which would change the meaning of mapping's position from "column header" to "headers".

No associated issue.

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

In certain scenarios mapping's value would be accidentally set to
None which would change the meaning of mapping's position from
"column header" to "headers".
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (ff79412) to head (f2d831f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   80.24%   80.27%   +0.03%     
==========================================
  Files          76       76              
  Lines        9970     9970              
  Branches     1475     1475              
==========================================
+ Hits         8000     8003       +3     
+ Misses       1626     1625       -1     
+ Partials      344      342       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 91b4979 into master Nov 4, 2024
13 checks passed
@soininen soininen deleted the fix_import_mapping_polishing branch November 4, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant