Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alternative filter #469

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix alternative filter #469

merged 1 commit into from
Nov 22, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Nov 22, 2024

Alternative filter was not dropping parameter values of incomplete multidimensional entities.

No associated issue.

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Alternative filter was not dropping parameter values of
incomplete multidimensional entities.
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.38%. Comparing base (1564a61) to head (b98016f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #469   +/-   ##
=======================================
  Coverage   80.37%   80.38%           
=======================================
  Files          76       77    +1     
  Lines       10025    10030    +5     
  Branches     1477     1477           
=======================================
+ Hits         8058     8063    +5     
  Misses       1625     1625           
  Partials      342      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@soininen soininen merged commit e4279c8 into master Nov 22, 2024
13 checks passed
@soininen soininen deleted the fix_alternative_filter branch November 22, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant