Skip to content

Commit

Permalink
Limit numpy<2 when building the bundle
Browse files Browse the repository at this point in the history
- It seems that PyInstaller 6.8.0 is not compatible with numpy 2.0+
- Removed hook-numpy.py because PyInstaller has it's own numpy hook with the same file name

Re #2852
  • Loading branch information
ptsavol committed Jun 19, 2024
1 parent 849a928 commit bf94cb8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/make_bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,17 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install "numpy<2" # See issue #2852. Remove when PyInstaller supports numpy 2.0+
python -m pip install -r requirements.txt
- name: Run tests
run: |
python -m unittest discover --verbose
- name: Install PyInstaller
run: |
python -m pip install PyInstaller
- name: List packages
run:
python -m pip list
- name: Download embeddable Python
run: |
mkdir embedded-python
Expand Down
3 changes: 0 additions & 3 deletions PyInstaller hooks/hook-numpy.py

This file was deleted.

0 comments on commit bf94cb8

Please sign in to comment.