Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopping execution with loop leaves some process alive #2925

Closed
soininen opened this issue Aug 30, 2024 · 0 comments · Fixed by spine-tools/spine-engine#150
Closed

Stopping execution with loop leaves some process alive #2925

soininen opened this issue Aug 30, 2024 · 0 comments · Fixed by spine-tools/spine-engine#150
Assignees
@soininen
Labels
bug Something isn't working

Comments

@soininen
Copy link
Contributor

I have a simple DAG with a loop. When I try to stop the execution, it seemingly works but the main Toolbox process keeps processing something and re-executing the project hangs.
@soininen soininen added the bug Something isn't working label Aug 30, 2024
@soininen soininen self-assigned this Aug 30, 2024
soininen added a commit to spine-tools/spine-engine that referenced this issue Sep 3, 2024
@soininen
Move Jump's default condition to class level field, add unit test
ce1e5cd 
No functional changes intended. I was hunting a transient bug in
Jump which turned out to be a "feature" when executing jumps under
PyCharm's debugger.

Re spine-tools/Spine-Toolbox#2925
soininen added a commit to spine-tools/spine-engine that referenced this issue Sep 3, 2024
@soininen
Propagate step failure to executor
6876546 
MultithreadExecutor.execute() must be notified if a step fails e.g.
due to user stopping the engine, otherwise it may end up looping
forever trying to execute items after Jumps that never finish.

Re spine-tools/Spine-Toolbox#2925
soininen added a commit to spine-tools/spine-engine that referenced this issue Sep 3, 2024
@soininen
Don't jump if any of jump's items isn't permitted to execute
6ba35fc 
Re spine-tools/Spine-Toolbox#2925
soininen added a commit that referenced this issue Sep 3, 2024
@soininen
Copy undo/redo data in undo command to prevent unintended modifications
56e774d 
Re #2925
This was referenced Sep 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soininen soininen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with jumps spine-tools/spine-engine
1 participant
@soininen