Fix scenario alternatives not removed correctly #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deletions were made in a scenario so that the rank order changed, all the scenario alternatives were not removed. This caused an error when the updated scen alt with the new rank number was attempted to be added back to the db. Re #2830
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2834 +/- ##
=======================================
Coverage 65.65% 65.65%
=======================================
Files 187 187
Lines 36204 36204
Branches 6178 6178
=======================================
Hits 23768 23768
Misses 11161 11161
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deletions were made in a scenario so that the rank order changed, all the scenario alternatives were not removed. This caused an error when the updated scen alt with the new rank number was attempted to be added back to the db.
Fixes #2830
Checklist before merging