Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to order tables by class dimension #2837

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Jun 12, 2024

  • Rows in tables are sorted by ascending dimension count
  • Switch from lexicographical to natural ordering. -> Now parameter2 belongs above parameter10.

Fixes #2711

Checklist before merging

  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

Henrik Koski added 2 commits June 12, 2024 15:54
- Rows in tables are sorted by ascending dimension count
- Switch from lexicographical to natural ordering.
  -> Now parameter2 belongs above parameter10.

Re #2711
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (b31813f) to head (f07e4fe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2837   +/-   ##
=======================================
  Coverage   65.64%   65.64%           
=======================================
  Files         187      187           
  Lines       36194    36209   +15     
  Branches     6177     6180    +3     
=======================================
+ Hits        23759    23770   +11     
- Misses      11160    11164    +4     
  Partials     1275     1275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit 5d4cd24 into master Jun 12, 2024
22 checks passed
@PiispaH PiispaH deleted the issue_2711_parameter_table_sorting branch June 12, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better ordering of parameters
1 participant