Make pasting into tables faster #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The row autocompletion is now disabled when data is pasted into a table. Pasting large amounts of data took a long time if the db had a lot of items in it already, because fetching the candidate entity classes from the db_map got slow. Now instead it is assumed that the user knows what they are doing and therefore when pasting data, the entity classes are correctly defined. Re #2867
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2870 +/- ##
=======================================
Coverage 66.85% 66.86%
=======================================
Files 187 187
Lines 36369 36384 +15
Branches 6229 6231 +2
=======================================
+ Hits 24316 24329 +13
- Misses 10754 10756 +2
Partials 1299 1299 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The row autocompletion is now disabled when data is pasted into a table. Pasting large amounts of data took a long time if the db had a lot of items in it already, because fetching the candidate entity classes from the db_map got slow. Now instead it is assumed that the user knows what they are doing and therefore when pasting data, the entity classes are correctly defined.
Re #2867
Checklist before merging