Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sorting more logical in db editor #2875

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Jul 4, 2024

  • Entity tree is now sorted by dimensionality, then by names.
  • values in SearchBarEditor are now sorted logically so that 11 comes after 10.

Fixes #2869, #2319

Checklist before merging

  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

Henrik Koski added 2 commits July 4, 2024 10:57
- Entity tree is now sorted by dimensionality, then by names.
- values in SearchBarEditor are now sorted logically so that 11 comes
  after 10.

Re #2869, #2319
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (c59fca2) to head (a794d6c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
- Coverage   66.87%   66.86%   -0.01%     
==========================================
  Files         187      187              
  Lines       36384    36383       -1     
  Branches     6231     6232       +1     
==========================================
- Hits        24332    24328       -4     
- Misses      10753    10756       +3     
  Partials     1299     1299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit 468fecb into master Jul 4, 2024
22 checks passed
@PiispaH PiispaH deleted the issue_2869_consistent_sorting branch July 4, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird sorting in entity_byname dropdown list
1 participant