Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PySide6 v6.8.1 #3024

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Support PySide6 v6.8.1 #3024

merged 3 commits into from
Dec 18, 2024

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Dec 17, 2024

This PR adds support for PySide6 6.8.1.

Fixed crashes by doing the following:

  • Inserted homeless Slots into a class that inherits from QObject in spine_engine_worker.py
  • Removed connecting the 'finished' by using lambda in project.py

Fixes #2980

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

- Allow PySide6 >=6.8.1
- Insert homeless Slots into a class in spine_engine_worker.py
- Remove lambda connection

Re #2980
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 69.44444% with 22 lines in your changes missing coverage. Please review.

Project coverage is 67.13%. Comparing base (ca3e446) to head (a6831f4).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/spine_engine_worker.py 67.74% 17 Missing and 3 partials ⚠️
spinetoolbox/widgets/settings_widget.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3024      +/-   ##
==========================================
- Coverage   67.15%   67.13%   -0.02%     
==========================================
  Files         193      193              
  Lines       37066    37071       +5     
  Branches     4445     4445              
==========================================
- Hits        24890    24888       -2     
- Misses      10919    10926       +7     
  Partials     1257     1257              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Don't allow 6.8.0
@ptsavol ptsavol merged commit fd040c3 into master Dec 18, 2024
17 of 18 checks passed
@ptsavol ptsavol deleted the issue_2980 branch December 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PySide6 6.8.x
1 participant