-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ProjectItemModel related stuff #187
Conversation
Do we use the item categories for anything after ProjectItemModel is gone? |
No, category.py is gone. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 0.8-dev #187 +/- ##
===========================================
+ Coverage 60.18% 60.66% +0.48%
===========================================
Files 194 193 -1
Lines 17789 17686 -103
Branches 2902 2875 -27
===========================================
+ Hits 10706 10729 +23
+ Misses 6509 6374 -135
- Partials 574 583 +9 ☔ View full report in Codecov by Sentry. |
That is so nice! We could then drop the category stuff from |
This PR removes ProjectItemModel dependency from spine-items
Fixes spine-tools/Spine-Toolbox#2560
Checklist before merging
Documentation (also in Toolbox repo) is up-to-dateRelease notes in Toolbox repo have been updated