Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ProjectItemModel related stuff #187

Merged
merged 13 commits into from
Feb 21, 2024

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Feb 16, 2024

This PR removes ProjectItemModel dependency from spine-items

Fixes spine-tools/Spine-Toolbox#2560

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

@ptsavol ptsavol self-assigned this Feb 16, 2024
@soininen
Copy link
Contributor

soininen commented Feb 16, 2024

Do we use the item categories for anything after ProjectItemModel is gone?

@ptsavol
Copy link
Member Author

ptsavol commented Feb 16, 2024

Do we use the item categories for anything after this change?

No, category.py is gone.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b86ccec) 60.18% compared to head (f080448) 60.66%.

Files Patch % Lines
...ne_items/data_transformer/specification_factory.py 0.00% 1 Missing ⚠️
...tems/data_transformer/widgets/class_tree_widget.py 0.00% 1 Missing ⚠️
.../data_transformer/widgets/parameter_tree_widget.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           0.8-dev     #187      +/-   ##
===========================================
+ Coverage    60.18%   60.66%   +0.48%     
===========================================
  Files          194      193       -1     
  Lines        17789    17686     -103     
  Branches      2902     2875      -27     
===========================================
+ Hits         10706    10729      +23     
+ Misses        6509     6374     -135     
- Partials       574      583       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen
Copy link
Contributor

No, category.py is gone.

That is so nice! We could then drop the category stuff from ItemInfo as well if that was not included in these PRs already.

@ptsavol ptsavol merged commit 826f75a into 0.8-dev Feb 21, 2024
10 checks passed
@ptsavol ptsavol deleted the remove_project_item_model_dependency branch February 21, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants