Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2223 mapping name importer source #214

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Jun 27, 2024

spine-tools/Spine-Database-API#423

Re spine-tools/Spine-Toolbox#2223

Checklist before merging

  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass
  • Change back to default requirements

Henrik Koski added 2 commits June 27, 2024 10:39
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 62.33%. Comparing base (752e7c7) to head (64c91d3).

Current head 64c91d3 differs from pull request most recent head a867b89

Please upload reports for the commit a867b89 to get more accurate results.

Files Patch % Lines
spine_items/importer/flattened_mappings.py 0.00% 4 Missing and 2 partials ⚠️
spine_items/importer/mvcmodels/mappings_model.py 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   62.36%   62.33%   -0.04%     
==========================================
  Files         168      168              
  Lines       17741    17750       +9     
  Branches     2951     2955       +4     
==========================================
- Hits        11065    11064       -1     
- Misses       6074     6080       +6     
- Partials      602      606       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit 93e1bce into master Jun 27, 2024
0 of 10 checks passed
@PiispaH PiispaH deleted the issue_2223_mapping_name_importer_source branch June 27, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant