Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2895 configure isort #217

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Issue 2895 configure isort #217

merged 3 commits into from
Jul 18, 2024

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Jul 17, 2024

No functional changes, just configured isort in pyproject.toml and ran it.

Re spine-tools/Spine-Toolbox#2895

Checklist before merging

  • Code has been formatted by black & isort
  • Unit tests pass

Henrik Koski added 3 commits July 17, 2024 16:57
No functional changes, just configured isort in pyproject.toml
and ran it.

Re spine-tools/Spine-Toolbox#2895
Removed unused imports and disabled pylint warnings on some lines.

Re spine-tools/Spine-Toolbox#2895
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 99.13420% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.36%. Comparing base (3f11246) to head (234f4ea).

Files Patch % Lines
...tems/data_transformer/widgets/class_tree_widget.py 0.00% 1 Missing ⚠️
.../data_transformer/widgets/parameter_tree_widget.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   62.37%   62.36%   -0.02%     
==========================================
  Files         168      168              
  Lines       17832    17826       -6     
  Branches     2979     2979              
==========================================
- Hits        11123    11117       -6     
  Misses       6104     6104              
  Partials      605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit 26d8edb into master Jul 18, 2024
11 of 12 checks passed
@PiispaH PiispaH deleted the issue_2895_configure_isort branch July 18, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant