This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
Feature/check cc and bcc fields #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Assert that the last email was bcc'ed to the given address. | ||
| * | ||
| * @param string $bcc | ||
| * @param Swift_Message $message |
There was a problem hiding this comment.
Do you want to use that, or the convention @param Swift_Message|null $message?
There was a problem hiding this comment.
I will make that change. Thanks.
There was a problem hiding this comment.
I have made that change, so this PR is ready to review again.
|
Coveralls never reported the test coverage. Can you manually trigger another commit to see if it will report? |
| ->getCc(), "No email was cc'ed to $cc."); | ||
|
|
||
| return $this; | ||
| } |
There was a problem hiding this comment.
Why not allow someone to pass in an array of emails for the CC and BCC tests?
There was a problem hiding this comment.
I made a separate issue for that #18 so I want to do that in a different feature.
…nto feature/checkCcAndBccFields
…nto feature/checkCcAndBccFields
ssfinney
added a commit
that referenced
this pull request
Feb 5, 2016
Feature/check cc and bcc fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added assertions for Cc, Bcc & Reply To. Closes #4, #5 & #8