Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Rename seeEmailsSent() to seeEmailCountEquals() #22

Merged
merged 4 commits into from
Feb 27, 2016
Merged

Rename seeEmailsSent() to seeEmailCountEquals() #22

merged 4 commits into from
Feb 27, 2016

Conversation

ssfinney
Copy link
Member

@ssfinney ssfinney commented Feb 6, 2016

Fixes #19

@jimmypuckett
Copy link
Member

@ssfinney I think that this looks great, but I think that we should consider keeping a seeEmailsSent method that calls the seeEmailCountEquals method? We could mark the seeEmailsSent method deprecated in the docblock.

This maybe a waste as there have been so few downloads at this time, but should we consider it?

@jimmypuckett
Copy link
Member

@ssfinney Also, you need to update the method name in the readme. Thanks.

@ssfinney
Copy link
Member Author

ssfinney commented Feb 6, 2016

@jimmypuckett I don't have a preference, so sure. What's the amount of time people typically keep deprecated methods?

Maybe we could take this change, and some of the "bigger" issues like #18 and #15, then make a new minor version (0.1.0). Also, do we need a changelog?

@ssfinney
Copy link
Member Author

@jimmypuckett I've made that change

jimmypuckett added a commit that referenced this pull request Feb 27, 2016
@jimmypuckett
Merge pull request #22 from spinen/feature/renameSeeEmailsSent
c506410 
Rename seeEmailsSent() to seeEmailCountEquals()
@jimmypuckett jimmypuckett merged commit c506410 into develop Feb 27, 2016
@jimmypuckett jimmypuckett deleted the feature/renameSeeEmailsSent branch February 27, 2016 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jimmypuckett jimmypuckett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssfinney @jimmypuckett