Implement Distro detection #84
Conversation
|
|
||
| config.Runtime.ConfigPath = distro.ConfigPath | ||
|
|
||
| if err := RunInstall(config, rootFs, hostFs, distro.Restarter(preset.Env{ConfigPath: distro.ConfigPath, HostFs: hostFs})); err != nil { |
There was a problem hiding this comment.
Not happy yet with how parts of the returned distro struct ends up in config and the restarter is passed as separate argument.
|
|
||
| if err := RunInstall(config, rootFs, hostFs, restarter); err != nil { | ||
| distro, err := DetectDistro(config, hostFs) |
There was a problem hiding this comment.
Not happy with this being duplicated in uninstall.go
|
I recently created an updated helm chart PR and noticed k3s support in runtime-class-manager's node-installer was still pending, which led me to this PR. I tested it and got things working on k3s with the following updates: https://github.com/spinkube/runtime-class-manager/compare/feat-autodetect-containerd-conf...vdice:autodetect-pr-84-updates?expand=1 Checking in to see if you'll have a chance to revisit this PR. I'd love to help, as I'm keen to sub runtime-class-manager in for kwasm-operator for SpinKube -- and for parity with the latter's node-installer, we'd need to make sure microk8s, rke2, k3s continue to be supported. (I haven't yet tested microk8s or rke2 from this PR, but can if that would be helpful.) |
|
Superseded by #240 |
Describe your changes
Implements some basic distro detection similar to what the shell script is doing (checking for existence of containerd configs in various places). This will also allow handling of special cases (e.g. RKE2 and K3s need their containerd config copied to a different file before modifying). This is needed for the manager to remain unaware of what exact distro is running on each node.
Issue ticket number and link
Checklist before requesting a review