refactor(kubernetes): convert scale manifest stage to react #10151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the refactoring of the Scale (Manifest) stage, part of the ongoing effort to transition Kubernetes stages to React. For additional context, please refer to spinnaker/spinnaker#4254
Changes Made
scaleManifestConfig.html
andscaleManifestConfig.controller.ts
have been converted into the new componentsScaleManifestConfig.tsx
andScaleManifestStageForm.tsx
.scaleSettingsForm.component.ts
has been converted into the newScaleSettingsForm.tsx
component. Note that this component is also used in/manifest/scale/scale.html
for the ad-hoc scale form, so it needs to be portable viareact2angular
until this angular template is converted to React.scale.controller.ts
andscale.html
files were adapted to use the new react-based component.UI Views
Stage Config
Execution Details Sections
Scale Manifest
Execution Details Tasks
Scale form