Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kubernetes): convert scale manifest stage to react #10151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cristhian-castaneda
Copy link
Member

Overview

This PR addresses the refactoring of the Scale (Manifest) stage, part of the ongoing effort to transition Kubernetes stages to React. For additional context, please refer to spinnaker/spinnaker#4254

Changes Made

  • Refactored Components:
    • The files scaleManifestConfig.html and scaleManifestConfig.controller.ts have been converted into the new components ScaleManifestConfig.tsx and ScaleManifestStageForm.tsx.
    • The file scaleSettingsForm.component.ts has been converted into the new ScaleSettingsForm.tsx component. Note that this component is also used in /manifest/scale/scale.html for the ad-hoc scale form, so it needs to be portable via react2angular until this angular template is converted to React.
    • The scale.controller.ts and scale.html files were adapted to use the new react-based component.

UI Views

Stage Config

image

Execution Details Sections

Scale Manifest

image

Execution Details Tasks

image

Scale form

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been a while since I looked at Angular -> React migration. Is there a reason we're leaving this as an Angular template and not just making it a React component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Matt, Yes, it has been a while! This PR is part of a broader plan to resume the migration effort incrementally.

Starting with this PR, we're breaking things down to keep reviews easier. I have two additional PRs lined up after this one to migrate the remaining stages listed in the referenced issue (spinnaker/spinnaker#4254). After those, the focus will shift to the Kubernetes infrastructure templates and controllers.

The following PRs might be a bit larger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants