fix(retrofit): use OkHttpClient from Kork

[mattgogerly]

Not sure why Gate has its own OkHttpClient, but by using the Bean from kork we get all the magic stuff like Brave tracing.

[dbyron-sf]

@mattgogerly would you mind linking to the bean in kork?

[mattgogerly]

@mattgogerly would you mind linking to the bean in kork?

Here.

So far as I can see Orca/Front50/Fiat already use it. I haven't checked anywhere else. Output from /beans for Fiat:

"okhttp3Client": {
  "aliases": [],
  "scope": "singleton",
  "type": "okhttp3.OkHttpClient",
  "resource": "class path resource [com/netflix/spinnaker/config/okhttp3/RawOkHttpClientConfiguration.class]",
  "dependencies": [
    "rawOkHttpClientConfiguration",
    "ok-http-client-com.netflix.spinnaker.okhttp.OkHttpClientConfigurationProperties",
    "spinnakerRequestHeaderInterceptor",
    "okHttp3MetricsInterceptor",
    "httpTracing"
  ]
}

[dbyron-sf]

OK, and then the idea is that this from gate's Main:

@SpringBootApplication(
  scanBasePackages = [
    "com.netflix.spinnaker.gate",
    "com.netflix.spinnaker.config"
  ],

picks it up because com.netflix.spinnaker.config.okhttp3 is part of com.netflix.spinnaker.config ?

[mattgogerly]

OK, and then the idea is that this from gate's Main:

@SpringBootApplication(
  scanBasePackages = [
    "com.netflix.spinnaker.gate",
    "com.netflix.spinnaker.config"
  ],

picks it up because com.netflix.spinnaker.config.okhttp3 is part of com.netflix.spinnaker.config ?

Correct. Also, the OkHttp3ClientConfiguration bean this was using is already coming from Kork.