refactor(web): no need to wrap SpinnakerHttpException

since it has a retryable property
spinnaker · Sep 19, 2023 · 5de31f6 · 5de31f6
1 parent fa41425
commit 5de31f6
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/igor-web/src/main/groovy/com/netflix/spinnaker/igor/jenkins/service/JenkinsService.java b/igor-web/src/main/groovy/com/netflix/spinnaker/igor/jenkins/service/JenkinsService.java
@@ -43,7 +43,6 @@
 import com.netflix.spinnaker.igor.service.BuildOperations;
 import com.netflix.spinnaker.igor.service.BuildProperties;
 import com.netflix.spinnaker.kork.core.RetrySupport;
-import com.netflix.spinnaker.kork.exceptions.SpinnakerException;
 import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerConversionException;
 import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerHttpException;
 import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerNetworkException;
@@ -329,9 +328,8 @@ private Response getPropertyFile(String jobName, Integer buildNumber, String fil
             if (e.getResponseCode() == 404 || e.getResponseCode() >= 500) {
               throw e; // retry on 404 and 5XX
             }
-            SpinnakerException ex = new SpinnakerException(e);
-            ex.setRetryable(false); // disable retry
-            throw ex;
+            e.setRetryable(false); // disable retry
+            throw e;
           } catch (SpinnakerNetworkException e) {
             throw e; // retry on network issue
           } catch (SpinnakerServerException e) {