fix(jenkins): Igor fails to start if only keystore is configured #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration worked fine in okhttp2, but not in okhttp3. As a workaround, Igor will try to use the keystore as a truststore as well, and prints a warning in the log.
jervi
changed the title
robzienert
reviewed
Oct 7, 2020
| if (trustManagers == null) { | ||
| log.warn("${host.name}: okhttp3 (unlike okhttp2) doesn't support configuring only a keystore without " + | ||
| "a truststore. Please configure a truststore to get rid of this message. Trying to use the " + | ||
| "keystore '${host.keyStore}' as a truststore as well. Your mileage may vary.") |
There was a problem hiding this comment.
Ah, I'm not sure we want to be advising this.
robzienert
requested changes
Oct 7, 2020
robzienert
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration worked fine in okhttp2, but not in okhttp3.
As a workaround, Igor will try to use the keystore as a truststore as well, and prints a warning in the log.
"Bug" introduced in #834. Keystore support was added in #596.