Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jenkins): Support for adding custom KeyStore for Jenkins clients #596

Merged
merged 5 commits into from
Jan 28, 2020
Merged

feat(jenkins): Support for adding custom KeyStore for Jenkins clients #596

merged 5 commits into from
Jan 28, 2020

Conversation

jervi
Copy link
Contributor

@jervi jervi commented Jan 22, 2020 

jenkins:
  masters:
    - address: "https://jenkins.com"
      name: spinnaker
      keyStore: /path/to/keystore.p12
      keyStoreType: PKCS12
      keyStorePassword: my_keystore_password

or

jenkins:
  masters:
    - address: "https://jenkins.com"
      name: spinnaker
      keyStore: /path/to/keystore.jks
      keyStorePassword: my_keystore_password

@jervi
feat(jenkins): Support for adding custom KeyStore for Jenkins clients
44db94e 
```
jenkins:
  masters:
    - address: "https://jenkins.com"
      name: spinnaker
      keyStore: /path/to/keystore.p12
      keyStoreType: PKCS12
      keyStorePassword: my_keystore_password
```
or
```
jenkins:
  masters:
    - address: "https://jenkins.com"
      name: spinnaker
      keyStore: /path/to/keystore.jks
      keyStorePassword: my_keystore_password
```
@jervi jervi requested a review from ajordens January 22, 2020 21:13
@jervi
Copy link
Contributor Author

jervi commented Jan 22, 2020

Kind of a continuation of #363.

@jervi
Copy link
Contributor Author

jervi commented Jan 27, 2020

@spinnaker/oss-reviewers PTAL

@robzienert robzienert added the ready to merge Approved and ready for merge label Jan 28, 2020
@mergify mergify bot added the auto merged label Jan 28, 2020
@mergify mergify bot merged commit f2fa552 into spinnaker:master Jan 28, 2020
@jervi jervi mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robzienert robzienert robzienert approved these changes

@ajordens ajordens Awaiting requested review from ajordens

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jervi @robzienert @spinnakerbot