Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Githubclient): make changes to Git(master|lab) and BitBucket… #1104

Merged
merged 7 commits into from
Sep 19, 2023
Merged

refactor(Githubclient): make changes to Git(master|lab) and BitBucket… #1104

merged 7 commits into from
Sep 19, 2023

Commits on Sep 19, 2023

  1. refactor(scm/test): replace RetrofitError with SpinnakerRetrofitError… 

    …Handler for custom error handling in Github, GitlabCi, BitBucket, ManagedScmDelivery
    @Luthan95 @SheetalAtre
    Luthan95 authored and SheetalAtre committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4678b61 View commit details
    Browse the repository at this point in the history

  2. refactor(scm/test): separated SpinnakerNetworkException and Spinnaker… 

    …HttpException exceptions for readability
    @SheetalAtre
    SheetalAtre committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ae8bd6a View commit details
    Browse the repository at this point in the history

  3. fix(scm): restore original behavior in GitHubCommitController, fix co… 

    …mpile error in ManagedDeliveryScmController
    @SheetalAtre
    SheetalAtre committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5986a78 View commit details
    Browse the repository at this point in the history

  4. fix(scm): restore original behavior in GitHubCommitController, restor… 

    …ed missing line for GitHubCommitController in catch of SpinnakerServerException
    @SheetalAtre
    SheetalAtre committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    077f873 View commit details
    Browse the repository at this point in the history

  5. fix(GitHubMaster,GitLabCommitController,ManagedDeliveryScmController)… 

    …: change Spinnaker*Exception handling code for readability
    @SheetalAtre
    SheetalAtre committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e91e09d View commit details
    Browse the repository at this point in the history

  6. refactor(web): add explicit SpinnakerNetworkException catch block in … 

    …scm/github/CommitController.compareCommits

to clean up the code / reduce instanceof checks
    @dbyron-sf
    dbyron-sf committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6ba1e70 View commit details
    Browse the repository at this point in the history

  7. Update igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github… 

    …/client/GitHubMaster.groovy
    @dbyron-sf
    dbyron-sf authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6d42494 View commit details
    Browse the repository at this point in the history