Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(JenkinsClient): make changes to jenkinsclient to use Spinnak… #1130

Merged
merged 8 commits into from
Sep 20, 2023
Merged

refactor(JenkinsClient): make changes to jenkinsclient to use Spinnak… #1130

merged 8 commits into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. refactor(JenkinsClient): make changes to jenkinsclient to use Spinnak… 

    …er custom exception instead of RetrofitError using SpinnakerRetrofitErrorHandler
    @Luthan95 @dbyron-sf
    Luthan95 authored and dbyron-sf committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    534a381 View commit details
    Browse the repository at this point in the history

  2. fix(JenkinsService): separate Spinnaker*Exceptions to handle retryabl… 

    …e conditions
    @SheetalAtre @dbyron-sf
    SheetalAtre authored and dbyron-sf committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    41c0f33 View commit details
    Browse the repository at this point in the history

  3. refactor(JenkinsService): add SpinnakerConversionException

    @SheetalAtre @dbyron-sf
    SheetalAtre authored and dbyron-sf committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2e19fe1 View commit details
    Browse the repository at this point in the history

  4. fix(JenkinsService): fix to make Spinnaker*Exceptions code handling r… 

    …eadable by removing redundant code
    @SheetalAtre @dbyron-sf
    SheetalAtre authored and dbyron-sf committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1ce8f0b View commit details
    Browse the repository at this point in the history

  5. fix(JenkinsService): fix to add SpinnakerServerException blocks which… 

    … were missed in previous commit
    @SheetalAtre @dbyron-sf
    SheetalAtre authored and dbyron-sf committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e4da027 View commit details
    Browse the repository at this point in the history

  6. fix(JenkinsService): remove catch block for SpinnakerServerException … 

    …from ScmDetails.getGitDetails() as no need to catch and rethrow
    @SheetalAtre @dbyron-sf
    SheetalAtre authored and dbyron-sf committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3728b50 View commit details
    Browse the repository at this point in the history

  7. refactor(web): remove unnecessary catch-and-throw from JenkinsService

    @dbyron-sf
    dbyron-sf committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    54281d3 View commit details
    Browse the repository at this point in the history

  8. refactor(web): no need to wrap SpinnakerHttpException 

    since it has a retryable property
    @dbyron-sf
    dbyron-sf committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7b08c77 View commit details
    Browse the repository at this point in the history