Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependency): add testImplementation of groovy-json dependency while upgrading to groovy 3.x #1172

Merged
merged 3 commits into from
Sep 21, 2023
Merged

chore(dependency): add testImplementation of groovy-json dependency while upgrading to groovy 3.x #1172

merged 3 commits into from
Sep 21, 2023

Commits on Sep 19, 2023

  1. chore(dependency): add testImplementation of groovy-json dependency w… 

    …hile upgrading to groovy 3.x

While upgrading groovy from 2.5.15 to 3.0.10, encountered following error during igor-web:test :
```
> Task :igor-web:compileTestGroovy
startup failed:
/igor/igor-web/src/test/groovy/com/netflix/spinnaker/igor/build/InfoControllerSpec.groovy: 32: unable to resolve class groovy.json.JsonSlurper
 @ line 32, column 1.
   import groovy.json.JsonSlurper
   ^
1 error
> Task :igor-web:compileTestGroovy FAILED
```
To resolve this issue added testImplementation of org.codehaus.groovy:groovy-json in igor-web.gradle.
    @j-sandy
    j-sandy committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5ca560a View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Merge branch 'master' into groovy3-upgrade

    @j-sandy
    j-sandy authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0aba05e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Merge branch 'master' into groovy3-upgrade

    @j-sandy
    j-sandy authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a34118f View commit details
    Browse the repository at this point in the history