fix(java17): add Jackson converter to RestAdapters to avoid Gson #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio update |
✅ Branch has been successfully updated |
jasonmcintosh
approved these changes
Sep 20, 2023
|
@Mergifyio backport release-1.32.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit c1bd0b1) # Conflicts: # igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/PluginMonitorConfig.java
mattgogerly
added a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mattgogerly
added a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mattgogerly
added a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Sep 20, 2023
…) (#1176) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#6881
If no converter is set for a RestAdapter it defaults to Gson, which uses reflection to set fields. JRE 17 says no bueno to that on classes like
Instantthat are now making fields inaccessible.