fix(jenkins): replacing retrofit error #1187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Oct 27, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/jenkins/JenkinsBuildMonitor.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Oct 27, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/jenkins/JenkinsBuildMonitor.groovy
Outdated
Show resolved
Hide resolved
|
From what I can tell, this isn't really tied to spinnaker/kork#1108. It's the getBuilds call inside the try/catch block that could throw a Spinnaker*Exception, via jenkinsService.getBuilds. The jenkinsClient inside JenkinsService comes from JenkinsConfig, which already (as of #1130) uses SpinnakerRetrofitErrorHandler. |
igor relies on the SpinnakerRetrofitHandler and it looks like this one got missed, which would cause the `getBuilds` method to fail if an exception occurred rather than happily carrying on. Signed-off-by: benjamin-j-powell <bjp@apple.com>
xibz
force-pushed
the
artifact-store-exceptions
branch
from
2c8de81
to
c4e0963
Compare
xibz
changed the title
dbyron-sf
reviewed
Oct 28, 2023
| @@ -43,6 +43,7 @@ dependencies { | |||
| implementation "org.codehaus.groovy:groovy" | |||
|
|
|||
| implementation "com.fasterxml.jackson.core:jackson-annotations" | |||
| implementation 'com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.13.1' | |||
|
included in #1188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
igor relies on the SpinnakerRetrofitHandler and it looks like this one
got missed, which would cause the
getBuildsmethod to fail if anexception occurred rather than happily carrying on.