Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Autobump korkVersion #1188

Merged
merged 3 commits into from
Oct 30, 2023

Commits on Oct 29, 2023

  1. chore(dependencies): Autobump korkVersion

    root committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    d88429d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. fix(web): fix exception handling in JenkinsBuildMonitor.processBuilds…

    …OfProject
    
    The jenkinsClient inside JenkinsService comes from JenkinsConfig, wihch, as of
    spinnaker#1130, uses SpinnakerRetrofitErrorHandler.
    Therefore, the getBuilds calls inside the try/catch block inside processBuildsOfProject
    throws a SpinnakerServerException.
    
    spinnaker#1130 updated the 'should continue processing other
    builds from a master even if one or more build fetches fail' test to throw a
    SpinnakerServerException with a RetrofitError as its cause instead of a RuntimeException
    with a RetrofitError as its cause.  With spinnaker/kork#1110, the
    SpinnakerServerException no longer has a RetrofitError as its cause.  It has the "mock
    root cause" exception as its cause.  But, because
    spinnaker/kork#1110 adds a url attribute to
    SpinnakerServerException, the cause is no longer necessary for including a url in the
    "Error communicating with jenkins" log message, and this commit updates the logic
    accordingly.
    dbyron-sf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a1f3049 View commit details
    Browse the repository at this point in the history
  2. refactor(web/test): clean up exception mocking in JenkinsBuildMonitor…

    …Spec
    
    remove unused runtimeException and rename retrofitEx since it's no longer a retrofitEx
    dbyron-sf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a581ba7 View commit details
    Browse the repository at this point in the history