refactor(artifact): moved artifacts (groovy) unit tests to artifacts (java) #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
May 31, 2024
igor-web/src/main/groovy/com/netflix/spinnaker/igor/artifacts/ArtifactExtractor.java
Outdated
Show resolved
Hide resolved
aman-agrawal
changed the title
dbyron-sf
reviewed
Jun 4, 2024
| @@ -37,7 +37,8 @@ public interface ArtifactService { | |||
| default List<String> getArtifactVersions( | |||
| @Nonnull String type, @Nonnull String name, String releaseStatus) { | |||
| List<String> releaseStatuses = new ArrayList<>(); | |||
| releaseStatuses.add(releaseStatus); | |||
| if (releaseStatus == null) releaseStatuses = null; | |||
There was a problem hiding this comment.
This is more than a refactor. Can we leave the logic changes for a subsequent PR please? It also seems like a strange line of code to add...does it do anything?
There was a problem hiding this comment.
Change reverted as this method is not called from unit test.
ArtifactServiceSpec method "service finds artifact versions"() called getArtifactVersions(String, String, List<String>)
To call same method from ArtifactServiceTest and to resolve the ambiguity issue between the overloaded methods, typecasted null with type List<String> in serviceFindsArtifactVersions()
…it tests to ArtifactExtractorTest (java)
…ests to ArtifactServiceTest (java)
dbyron-sf
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VisibleForTesting--
"service finds artifact versions"()calledgetArtifactVersions(String, String, List<String>)To call same method from ArtifactServiceTest and to resolve the ambiguity issue between the overloaded methods, typecasted null with type
List<String>.