refactor(gcb): Further clean-up of GCB config #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we are enforcing a non-null account name and project downstream, let's enforce them at object creation to make things cleaner. This commit also removes the subscriptionName field; it is part of the config but not needed by igor, so there's no sense mapping it. Finally, make jsonKey an optional to better reflect that it is optional (instead of treating an empty string as a sentinel value).
maggieneterval
approved these changes
May 12, 2020
plumpy
approved these changes
May 12, 2020
cfieber
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we are enforcing a non-null account name and project downstream, let's enforce them at object creation to make things cleaner.
This commit also removes the subscriptionName field; it is part of the config but not needed by igor, so there's no sense mapping it.
Finally, make jsonKey an optional to better reflect that it is optional (instead of treating an empty string as a sentinel value).